Live singles fits plot names #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtrevor
approved these changes
Aug 20, 2024
|
Please rebase on master to pick up #4855 and get the tests to pass. |
Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* Forgot to remove unused test options * Dont report all ifos in significance plots * Update bin/live/pycbc_live_supervise_collated_trigger_fits Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr> * Update bin/live/pycbc_live_supervise_collated_trigger_fits Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr> * Update bin/live/pycbc_live_supervise_collated_trigger_fits Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr> --------- Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an annoyance in the naming of single significance plots for each IFO.
Also remove unused options
Standard information about the request
This is a minor fix
This change affects the live search
This change changes naming of live automatically produced plots
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Contents
Change to use a daily singles fit filename format which uses IFOs, and then replaces that string for the single-ifo plots
Testing performed
Supervisor script still runs and makes plots with the appropriate name (once the config is updated as appropriate)