Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert temporary dependence on PyPMC fork #4874

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

titodalcanton
Copy link
Contributor

@titodalcanton titodalcanton commented Sep 11, 2024

This reverts a temporary measure added in #4863 due to CI tests failing because of PyPMC. With #4863 we started depending on a custom branch of PyPMC to work around an error, and I think the underlying issue has now been addressed in PyPMC.

Fixes #4861.

  • The author of this pull request confirms they will adhere to the code of conduct

Copy link
Member

@ahnitz ahnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titodalcanton Looks like this is good to go.

@ahnitz ahnitz merged commit 5e23aa7 into gwastro:master Sep 12, 2024
30 checks passed
@titodalcanton titodalcanton deleted the revert-custom-pypmc branch September 12, 2024 14:03
prayush pushed a commit to prayush/pycbc that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests failing with pypmc build error
2 participants