Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for v2.3.8 #4893

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Changes for v2.3.8 #4893

merged 4 commits into from
Sep 25, 2024

Conversation

spxiwh
Copy link
Contributor

@spxiwh spxiwh commented Sep 25, 2024

Adding some additional patches for the v238 branch.

tdent and others added 2 commits September 25, 2024 08:24
…4882)

* Update offline source probability for changes to mchirp area

* Update pycbc_source_probability_offline

It still didn't work from Thomas' change, we needed a further fix for the missing gap entry. Also, even if we run the source probabilities offline with the 'include mass gap' option, the output file doesn't have a mass gap entry.

* Remove mass gap option entirely

Offline probabilities no longer to support mass gap

* remove more mass gap code

---------

Co-authored-by: AnaLorenzoMedina <114947731+AnaLorenzoMedina@users.noreply.github.com>
@spxiwh spxiwh requested a review from tdent September 25, 2024 15:26
* Depndabot

* Try to solve new issue due to upload-artifact@v2 deprecation

* Mimic what has been changed for PyPMC

* Still failing, try this…

* Include a fix for Node16 deprecation as well

* Fix one more error

* Also update setup-python to v5

* Remove some debugging stuff

---------

Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
Copy link
Contributor

@tdent tdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, assuming the tests pass

@spxiwh spxiwh merged commit d6e94f5 into gwastro:v23_release_branch Sep 25, 2024
31 checks passed
@spxiwh spxiwh deleted the v238_changes branch September 25, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants