Make coinc_statmap work in the case that no foreground is present #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prasia-Pankunni
approved these changes
Oct 18, 2024
Prasia-Pankunni
approved these changes
Oct 18, 2024
|
I forgot that reviewers need write access - @spxiwh ? |
spxiwh
approved these changes
Oct 23, 2024
pannarale
pushed a commit
to pannarale/pycbc
that referenced
this pull request
Nov 7, 2024
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prasia found a bug in pycbc_coinc_statmap if no foreground events have been found,
this fixes that
Standard information about the request
This is a: bug fix
This change affects: the offline search
This change changes: nothing
This change: has been proposed using the contribution guidelines
Motivation
Fix bug for a legitimate use-case in the offline search
Contents
A variable was being used later in the code which was only set in the case that there was some foreground
This sets the variable and ensures that it is usable later
Links to any issues or associated PRs
#4907
Testing performed
To be tested with downstream codes