Introducing syntax for vetoing injections in PyGRB and final version of pycbc_pygrb_plot_null_stats
#4947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e apply_vetoes_to_found_injs for the time being)
|
@MarcoCusinato, thinking about your comments in #4941, I introduced a new function ( |
MarcoCusinato
approved these changes
Nov 20, 2024
pannarale
commented
Nov 20, 2024
Thanks! |
1 task
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
…of `pycbc_pygrb_plot_null_stats` (gwastro#4947) * Introducing a (mute) apply_vetoes_to_found_injs function in PyGRB * Version of pycbc_pygrb_plot_null_stats with vetoes (albeit with a mute apply_vetoes_to_found_injs for the time being) * Small cleanup * Addresing typos * Update bin/pygrb/pycbc_pygrb_plot_null_stats --------- Co-authored-by: Marco Cusinato <marco.cusinato.96@gmail.com>
This was referenced Nov 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fourth in the series started in PR #4929.
Standard information about the request (and the following ones that will be linked to this)
This is a: a new feature enabling veto definer file usage in PyGRB. Utilities and scripts in results production are being streamlined along the way.
This change affects: PyGRB
This change changes: result presentation / plotting and scientific output.
Should this change break the standard automated test running
--helpfor PyGRB plotting scripts, I will add some workarounds to avoid this. If needed, these will likely be empty functions: the plotting scripts will be progressively renovated in the whole series of PRs.Motivation
Now that the workflow generator passes the veto definer file to the jobs where needed, its usage in the PyGRB results scripts is possible.
Contents
pycbc_pygrb_plot_null_stats.apply_vetoes_to_found_injsis introduced. At the moment it does not veto any injections (this will be a dedicated PR) but it introduces the syntax all results scripts will need to follow.Testing performed
The totality of the changes that will be broken down in multiple PRs was tested on GRB 170817A data by producing a full results webpage (see here).