Pass kwargs to pool constructor in choose_pool
#4949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass keyword arguments passed to
choose_pool
to the pool constructor. This enables additional configuration of the pool.Standard information about the request
This is a: bug fix
This change affects:
pycbc_bruke_bank
, inference. However, sincechoose_pool
is never called with any keyword arguments, things are functionally the same.This change changes: configuration
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8)
This change is backwards compatible
Motivation
This enables specifying e.g.
initalizer
andinitargs
when creating a pool. Both the defaultmultiprocessing
library andschwimmbad
support these arguments.This will allow me to improve how the multiprocessing pool is configured for
nessai
, which will be a subsequent PR.Contents
I've added
kwargs
tochoose_pool
. I've also updatedSinglePool
to allow arbitrary keyword arguments, this is consistent withSerialPool
fromschwimmbad
.Links to any issues or associated PRs
N/A
Testing performed
The changes are covered by existing tests.
Additional notes