Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of output/upload value issues in pycbc live #4953

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix a couple of output/upload value issues in pycbc live #4953

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f739cd2
get singles back to being reduced chisquared in uploads
GarethCabournDavies Nov 22, 2024
d232c59
Save ranking statistic information in the "likelihood" part of the co…
GarethCabournDavies Nov 22, 2024
2bde00f
Not all CandidateForGraceDB will have stat in the coinc_results
GarethCabournDavies Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pycbc/events/single.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ def check(self, trigs, data_reader):

# fill in a new candidate event
candidate = {
f'foreground/{self.ifo}/{k}': cutall_trigs[k][i] for k in trigs
f'foreground/{self.ifo}/{k}': cut_trigs[k][sngl_idx][i]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the change to this line? Why do we need sngl_idx here now when we didn't before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cutall_trigs already had the sngl_idx included (line 285 above), but cut_trigs doesnt have that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed the change from cutall_trigs to cut_trigs

for k in trigs
}
candidate['foreground/stat'] = rank[i]
candidate['foreground/ifar'] = ifar
Expand Down
2 changes: 1 addition & 1 deletion pycbc/io/gracedb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def __init__(self, coinc_ifos, ifos, coinc_results, **kwargs):
coinc_event_row.time_slide_id = lsctables.TimeSlideID(0)
coinc_event_row.process_id = proc_id
coinc_event_row.coinc_event_id = coinc_id
coinc_event_row.likelihood = 0.
coinc_event_row.likelihood = coinc_results['foreground/stat']
titodalcanton marked this conversation as resolved.
Show resolved Hide resolved
coinc_event_table.append(coinc_event_row)
outdoc.childNodes[0].appendChild(coinc_event_table)

Expand Down
Loading