Ranking statistic documentation fix #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-statistic.rst file
…ly overwritten page name
WuShichao
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shichao noticed that the ranking statistic page wasn't displaying properly, and that the
searchpage just doesn't show anything at all.The ranking statistic page was broken as there were some unprintable characters (thanks copilot).
The search page looks like it was being overwritten by the search.html being used to actually make the search functionality
Standard information about the request
This is a bug fix
This change changes documentation
This change has been proposed using the contribution guidelines
Contents
Clean up unprintable characters, rename
searchto searches`Testing performed
Ranking statistic page now loads properly in the github preview
https://github.com/GarethCabournDavies/pycbc/blob/documentation_fix/docs/searches/ranking_statistic.rst
As opposed to
https://github.com/gwastro/pycbc/blob/dc2bad6/docs/search/ranking_statistic.rst
Search issue is something that I think will not have evidence that it has worked until this is merged