Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parsing failure on some track lines #3

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

LB767
Copy link
Contributor

@LB767 LB767 commented Sep 15, 2023

For some reason, the following line fails to parse when getting tracks
G20 FF 60200 005000 780 383 1239 -4107668 43 14220 24 25 18 123 -10 75 -4 75 -4 16 0 0 L3P 05
when trying to get the checksum value.
Line 411 panics not finding the characters.
It must have to do with formatting hex doing some weird stuff which I have no clue about.
Simplifying this to just get the string works fine since the actual checksum check is commented out anyway, and converting to hex can be done then if needed

@gwbres
Copy link
Owner

gwbres commented Sep 15, 2023

Welcome onboard @LB767 👋 and thanks for your contribution.

I'm mostly focused on my RINEX crate these days, but I'll get back soon with some very interesting CGGTTS ops.
I'll be happy to merge contributions in the meantime

@gwbres
Copy link
Owner

gwbres commented Sep 15, 2023

I think I commented out the checksum verification because I could not find a common ground between the specifications and the examples they provide

@gwbres gwbres merged commit 5d104ab into gwbres:main Sep 15, 2023
@gwbres
Copy link
Owner

gwbres commented Sep 15, 2023

just released a v3.2.2 FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants