Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python <= 3.6 #66

Merged
merged 6 commits into from
Mar 13, 2022
Merged

Drop support for EOL Python <= 3.6 #66

merged 6 commits into from
Mar 13, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Apr 22, 2021

Also move testing from Travis CI to GitHub Actions

Move coverage from Coveralls to Codecov

Run Flake8 via pre-commit

  • Pins versions
  • Makes it easy to run on CI and as optional pre-commit hook
  • Add some other handy pre-commit fixers/linters too

Here's the pip installs for isodate from PyPI for March 2021, showing low numbers for EOL versions:

category percent downloads
3.7 51.39% 16,518,933
3.6 25.40% 8,165,006
3.8 10.28% 3,305,128
3.5 4.76% 1,529,899
2.7 3.16% 1,016,819
null 3.06% 982,390
3.9 1.92% 617,791
3.4 0.03% 10,536
3.10 0.00% 540
3.3 0.00% 15
2.6 0.00% 13
Total 32,147,070

Date range: 2021-03-01 - 2021-03-31

Source: pip install -U pypistats && pypistats python_minor isodate --last-month

@gweis
Copy link
Owner

gweis commented Dec 12, 2021

I think most of it is included in #68 as well ?

@hugovk hugovk changed the title Drop support for EOL Python < 3.6 Drop support for EOL Python <= 3.6 Dec 12, 2021
@hugovk
Copy link
Contributor Author

hugovk commented Dec 12, 2021

About half was in #68, I've now updated this. Thanks!

@hugovk
Copy link
Contributor Author

hugovk commented Dec 12, 2021

Or rather, I'll update this tomorrow :)

@gweis
Copy link
Owner

gweis commented Dec 13, 2021

from a quick glance it's only some code modernisation and formatting ... and some packaging (setup.cfg)
I am planning to move this project to poetry (pyproject.toml) and use black in the pre-commit-hook for consistent code formatting.

that should then cover everything I think.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #66 (68a4bbe) into master (d0eb6b9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          10       10           
  Lines         497      497           
=======================================
  Hits          469      469           
  Misses         28       28           
Flag Coverage Δ
GHA_Ubuntu 94.36% <100.00%> (ø)
GHA_Windows 94.36% <100.00%> (ø)
GHA_macOS 94.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/isodate/duration.py 93.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0eb6b9...68a4bbe. Read the comment docs.

@hugovk
Copy link
Contributor Author

hugovk commented Dec 13, 2021

Sounds good!

This adds workflow_dispatch to GHA which adds a button to be able to trigger builds, fixes the CI to build pypy-3.8 because pypy3 is deprecated and will be removed, simplify the cache config, adds some extra things to pre-commit, deletes redundant setup.cfg because universal wheels are only for Python 2 and 3, add python_requires to help pip install the right library version for the user's Python.

@eggplants
Copy link

Any updates?

@eggplants eggplants mentioned this pull request Mar 12, 2022
@gweis gweis merged commit 14aefdd into gweis:master Mar 13, 2022
@hugovk hugovk deleted the test-gha branch March 13, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants