Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prop ariaLabel #701

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove prop ariaLabel #701

merged 1 commit into from
Oct 10, 2023

Conversation

flavia-moraes
Copy link
Collaborator

@flavia-moraes flavia-moraes commented Oct 9, 2023

JIRA Issue

Description 📄

Removes the ariaLabel prop for the aria-label attribute, thus leaving the native use of the attribute as an accessible element. The ariaLabel property will be maintained only for the Icon component as part of the accessible identifier for elements such as title and description.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

Removes the ariaLabel prop for the aria-label attribute, thus leaving the native use of the attribute as an accessible element. The ariaLabel property will be maintained only for the Icon component as part of the accessible identifier for elements such as title and description.

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@flavia-moraes flavia-moraes marked this pull request as draft October 9, 2023 20:23
@flavia-moraes flavia-moraes marked this pull request as ready for review October 9, 2023 20:26
Copy link

@AnaGomes-PiPolaris AnaGomes-PiPolaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@flavia-moraes flavia-moraes merged commit 15d472e into master Oct 10, 2023
3 checks passed
@flavia-moraes flavia-moraes deleted the fix/aria-label branch October 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants