Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-833] - System theme typing #825

Merged
merged 4 commits into from
Jun 14, 2024
Merged

[DS-833] - System theme typing #825

merged 4 commits into from
Jun 14, 2024

Conversation

evilamaior
Copy link
Contributor

@evilamaior evilamaior commented Jun 3, 2024

DS-833

Description 📄

  • Add TS to system package

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

  • Run the project and check the documentation

  • Unit Test

  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

not applicable

@evilamaior evilamaior changed the title [DS-833] [DS-833] - Theme typing Jun 6, 2024
@evilamaior evilamaior changed the title [DS-833] - Theme typing [DS-833] - System theme typing Jun 6, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@flavia-moraes flavia-moraes marked this pull request as ready for review June 14, 2024 14:32
@flavia-moraes flavia-moraes merged commit 1f049aa into master Jun 14, 2024
3 of 4 checks passed
@flavia-moraes flavia-moraes deleted the DS-833 branch June 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants