Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/remove default props from yoga/web #866

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lpolon
Copy link
Contributor

@lpolon lpolon commented Jan 24, 2025

JIRA Issue

Description 📄

remove React defaultProps in favor of js default parameters

with the release of React 19, the React team also release React 18.3
that adds warnings in order to streamline the upgrade to react 19.

Running the yoga/web components on a project with React 18.3 raised the
warning suggesting to replace the default props API in favor of the
standard ES6+ default parameters

relevant links:

WIP: broken snapshot test

[Enter the description of your changes]

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes -> WIP
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

WIP

with the release of React 19, the React team also release React 18.3
that adds warnings in order to streamline the upgrade to react 19.

Running the yoga/web components on a project with React 18.3 raised the
warning suggesting to replace the default props API in favor of the
standard ES6+ default parameters

relevant links:
- https://react.dev/blog/2024/04/25/react-19-upgrade-guide
- https://stackoverflow.com/questions/78931633/warning-page-support-for-defaultprops-will-be-removed-from-function-components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant