Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CUS-1729 repo setup #1

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Feature: CUS-1729 repo setup #1

merged 4 commits into from
Feb 21, 2024

Conversation

emmaLP
Copy link
Contributor

@emmaLP emmaLP commented Feb 21, 2024

JIRA ticket link/s

Summary of changes

  1. Initial outline of the READ for the repo
  2. Adding CODEOWNERS, dependabot and pr template config
  3. simplifying gitgnore file

Additional Info

This is a public repo so we need to ensure we are keeping things as generic as possible.

Out scope is to leverage this in Auth0 actions for logging and metrics

Copy link

@alexdunne alexdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Does this need to be public?
  • What does this library provide over https://www.npmjs.com/package/datadog-metrics. README makes reference to it being a wrapper but doesn't explain why we need a wrapper or the problem this library solves

@emmaLP
Copy link
Contributor Author

emmaLP commented Feb 21, 2024

@alexdunne

  • Does this need to be public?

We have to publish the npm package as public in order to use it in Auth0 Actions. It made sense to make the repo public too since anyone could use the package once published to npm.

The metrics side will either return the datadog-metrics client or a no-op client to support sampling logic we currently have in auth0 rules. Since actions cannot share config like rules can, the sampling logic will need to it in this package and just return the relevant client. This line here in the README mentions about the sampling logic and what type of client is returned

@emmaLP emmaLP requested a review from alexdunne February 21, 2024 14:35
@emmaLP emmaLP merged commit edaa3ab into main Feb 21, 2024
1 check passed
@emmaLP emmaLP deleted the feature/CUS-1729_repo_setup branch February 21, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants