Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CUS-1729 fix export type #8

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Fix: CUS-1729 fix export type #8

merged 3 commits into from
Feb 27, 2024

Conversation

emmaLP
Copy link
Contributor

@emmaLP emmaLP commented Feb 26, 2024

JIRA ticket link/s

Summary of changes

  1. Updating export type in comments as it was not exposing the functions of the BufferedMetricsLogger with the previous return type
  2. Adding a call to increment a metric on a test to ensure they are exported correctly

Additional Info

@emmaLP emmaLP requested review from a team as code owners February 26, 2024 17:47
Copy link

codacy-production bot commented Feb 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6a4c0e8) 56 56 100.00%
Head commit (e341eeb) 56 (+0) 56 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#8) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@emmaLP emmaLP merged commit 8df26d3 into main Feb 27, 2024
7 checks passed
@emmaLP emmaLP deleted the fix/CUS-1729_fix_export_type branch February 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants