Make instantiation of Grounder more flexible #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgyori
approved these changes
Feb 6, 2024
bgyori
force-pushed
the
grounder-input
branch
from
a2fa7a6 to
d88a6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add any kind of iterable as the argument to
gilda.Grounderinstead of limiting to just lists. This is useful since there are several functions in various places that generate iterables of Gilda Term objects that would be convenient to directly stick in aGrounderwithout having to cast to a list. This PR also adds some tests to check all of the various ways a Grounder can be instantiated