Add argument for default host attributes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacman99
changed the title
Pacman99
changed the title
blaggacao
reviewed
Apr 7, 2021
gytis-ivaskevicius
approved these changes
Apr 8, 2021
blaggacao
approved these changes
Apr 8, 2021
|
@gytis-ivaskevicius we where wondering if you wanted to preserve We can see how usage plays out and make that call whonce we get there. |
|
I'd like to preserve Related: divnix/digga#232 (comment) |
Pacman99
changed the title
blaggacao
pushed a commit
that referenced
this pull request
Apr 8, 2021
This reverts commit faa7855, reversing changes made to 8a593ca. ``` evalHostArgs = { channelName ? "nixpkgs" , modules ? [] , system ? defaultSystem , extraArgs ? {} , ... }: defaultHostAttrs // { inherit channelName system; modules = sharedModules ++ modules; extraArgs = sharedExtraArgs // extraArgs; }; ``` does not as intended. - channelName would be "nixpkgs" even if a default is set.
blaggacao
pushed a commit
that referenced
this pull request
Apr 8, 2021
This reverts commit fe983e5.
blaggacao
pushed a commit
that referenced
this pull request
Apr 9, 2021
This reverts commit fe983e5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic argument to add defaults to all hosts. This could cover modules, extraArgs, system, and channelName. I would say keep some things, ex
sharedModules, just for convenience and backwards-compatibility, but this is overall useful to prevent making the api surface too large. Whenever adding things to hosts, you no longer need to make a relevant default argument, users can just usedefaultHostAttrs.Example: