General exporter and builderConstructor improvements #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure whats up with the nixpkgs-fmt check, I ran it on my system and the file doesn't get changed. |
|
This depends on numtide/flake-utils#31 |
Pacman99
force-pushed
the
cleanup-exporters
branch
from
720c414
to
7abe2f1
Compare
blaggacao
approved these changes
Apr 25, 2021
Pacman99
force-pushed
the
cleanup-exporters
branch
2 times, most recently
from
77619dc
to
16b5733
Compare
Pacman99
force-pushed
the
cleanup-exporters
branch
from
16b5733
to
919cdc1
Compare
|
This should be ready to go, I just changed the commit to update flake-utils, since the fixup PR has been merged. |
gytis-ivaskevicius
approved these changes
Apr 25, 2021
Closed
use pkgs to collect overlays from each channel, since user only passes overlaysBuilder for each channel. Also filter out any overlays defined in inputs
Pacman99
force-pushed
the
cleanup-exporters
branch
from
919cdc1
to
b75b8f3
Compare
added 2 commits
April 25, 2021 13:07
This is intended to be self.overlays which allows a cleaner api to pass what overlays should be collected and used to create packages export
specifically packagesFromOverlaysBuilderConstructor and overlaysFromChannelsExporter
Pacman99
force-pushed
the
cleanup-exporters
branch
from
b75b8f3
to
e3ba667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some fixups and improvments to the api for the overlaysFromChannelsExporter and packagesFromOverlaysBuilderConstructor.
Have overlays exporter take
self.pkgsandinputs. The former is so nixpkgs sets are instantiated and the overlay lists are ready. The latter is to auto filter any overlays that were taken from inputs. Its not good to export things that weren't originated in your flake and you don't plan on maintaining.Change packages builderConstructor to just take an attrset of overlays and the builder can then pull out packages defined in overlays from the channels set.