Refactor key press management in dialog settings #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comments in review : * gyunaev#588 (comment)
…tion with keystroke See comments in review : * gyunaev#588 (review)
Abestanis
approved these changes
Feb 21, 2024
…ead NULL See comment in review : * gyunaev#589 (comment)
…guages Reordering are made by cmake --build . in ./build folder (With Qt5LinguistTools)
Abestanis
reviewed
Feb 21, 2024
MathiusD
added a commit
to MathiusD/birdtray
that referenced
this pull request
Feb 21, 2024
See comments in review : * gyunaev#589 (comment)
See comments in review : * gyunaev#589 (comment)
MathiusD
force-pushed
the
feature/refactor_key_press_management_in_dialog_settings
branch
from
e993705 to
92f41d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following review and comments in #588
Following PR include following modifications :