metrics: add missing calls to Ticker.Stop in tests (ethereum#20866)

gzliudan · Dec 13, 2024 · 1415bb6 · 1415bb6
1 parent 47ce406
commit 1415bb6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/metrics/meter_test.go b/metrics/meter_test.go
@@ -26,6 +26,7 @@ func TestMeterDecay(t *testing.T) {
 		ticker: time.NewTicker(time.Millisecond),
 		meters: make(map[*StandardMeter]struct{}),
 	}
+	defer ma.ticker.Stop()
 	m := newStandardMeter()
 	ma.meters[m] = struct{}{}
 	go ma.tick()

diff --git a/metrics/sample_test.go b/metrics/sample_test.go
@@ -346,6 +346,7 @@ func TestUniformSampleConcurrentUpdateCount(t *testing.T) {
 	quit := make(chan struct{})
 	go func() {
 		t := time.NewTicker(10 * time.Millisecond)
+		defer t.Stop()
 		for {
 			select {
 			case <-t.C: