Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select a direction for overflow #91

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

kw510
Copy link
Contributor

@kw510 kw510 commented Mar 22, 2024

Unsure on the naming of the properties, happy for feedback :)

@h-kanazawa
Copy link
Owner

@kw510 Thank you for PR. Could you explain your motivation for this PR? For example, you'd like to ignore overflow on one of directions.

@kw510
Copy link
Contributor Author

kw510 commented Mar 25, 2024

Heya @h-kanazawa, I would like to ignore overflow on width. This is for a show more on some text content.

If the text exceeds the width, but not the height, as i don't need a show more displaying when it exceeds the width.

I think a better way to do this is to split overflow into overflow-x and overflow-y. wdut?

@h-kanazawa
Copy link
Owner

OK, it sounds reasonable. I'll test your change within 1 week.

Unsure on the naming of the properties

This library is a wrapper of react-resize-detector. The names of handleWidth and handleHeight does match with react-resize-detector. The naming is good 👍

@h-kanazawa h-kanazawa merged commit 6736af3 into h-kanazawa:master Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants