Skip to content

Commit

Permalink
Added new section in product features to handle common UI features
Browse files Browse the repository at this point in the history
- Any features that are common thru out the UI, are accessible from multiple screens in UI can live in this section. Example of such feature is Advanced search that is available thru out the UI and cannot be added as an individual feature under any one section.
- New feature added in this PR addresses an issue where in the past only Super Admin user and Admin user could add Global filters for everyone to see, but now as we have different types of Admin users it is better to have this as a product feature. Without this fix currently anyone can add global filters in UI.

This PR addresses issues mention in ManageIQ/manageiq-ui-classic#6253
  • Loading branch information
h-kataria committed Mar 3, 2020
1 parent 91176bd commit 2b21af0
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
21 changes: 21 additions & 0 deletions db/fixtures/miq_product_features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6629,3 +6629,24 @@
:description: Order cart
:feature_type: control
:identifier: sui_cart_order

# Common UI related features that are available thru several places in UI
- :name: Common Features in UI
:description: Common Features in UI
:feature_type: node
:hidden: false
:identifier: common_features
:children:
# Advanced search thru out UI
- :name: Search
:description: Advanced Search
:feature_type: node
:hidden: false
:identifier: advanced_search
:children:
# Ability to add global search filter
- :name: Add Global Filters
:description: Ability to add global filter
:feature_type: control
:hidden: false
:identifier: add_global_filter
1 change: 1 addition & 0 deletions db/fixtures/miq_user_roles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
:read_only: true
:miq_product_feature_identifiers:
- about
- add_global_filter
- all_vm_rules
- automation_manager
- embedded_automation_manager
Expand Down

0 comments on commit 2b21af0

Please sign in to comment.