-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AVIF support #356
Adds AVIF support #356
Conversation
We'll perhaps need a newer libheif in the CI image if we want to keep the test for it. |
* This adds a new type AVIF to the supported type list if libvips >= 8.9.0 * Calls libheif through libvips with the AV1 compression set to save AVIF images.
Test is slow but passing for now. Looks like the libaom en-/decoder is easiest to install for us in CI but a little on the slow side in terms of encoding performance. There's also the option to use https://code.videolan.org/videolan/dav1d/ as decoder and https://github.com/xiph/rav1e as encoder with libheif. Both have more dependencies and would involve more changes as we'd need to compile them from source it seems, so I'd opt to stay with libaom for this use-case. |
…output only means to save is required
Add avif test photo, that I had forgotten
Thanks for the PR! Is this ready? |
Good to go from my end! 👍 |
Tried making it work, Getting following error
|
That is the error libheif returns if it isn’t compiled with a AVIF encoder or decoder. Can you try recompiling a recent libheif from source with the rav1e or libaom encoder? I think that should make the error disappear. I am on the go right now, but if it helps can also supply a container image that works - it works inside the travis CI tests of this PR too btw, where I install libaom and compile libheif from source. |
Got it to work by compiling. |
First of all: Glad to hear you got AVIF processing working! |
The latest updates work and Metadata is working fine. It was somewhat of effort to make it work with libheif. I think this step should be added un readme or we should wait for libheif release with avif support to release. |
Awesome - can you review the sections I added to the README? Mostly only referring to the documentation on the libheif side - no need to duplicate the information in my opinion. |
This looks good, Although I have a question. https://github.com/strukturag/libheif/releases mentions that they support avif from version 1.8.0. So why we need to compile libheif for this? |
AVIF support has been in
Any one of these are libraries need to be present for For now So for now the of |
Hi, is anything still needed to get this merged? |
Thanks for the nice work done, and apologies for the latency, OSS is not nowadays something I can spend much time on, unfortunately. |
Cheers @h2non, absolutely understandable and relatable 👍 |
AVIF
to the supported type list if libvips >= 8.9.0 is installed.This should fix #353.