Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Alteryx support for DAI version 1.9.1 #25

Open
wants to merge 4 commits into
base: am/alteryx_dai_190
Choose a base branch
from
Open

Add Alteryx support for DAI version 1.9.1 #25

wants to merge 4 commits into from

Conversation

achraf-mer
Copy link

@achraf-mer achraf-mer commented Mar 7, 2021 •
edited
Loading

This shall adapt the current plugins to 1.9.1.x

Available at: https://h2oai-alteryx-release.s3.amazonaws.com/release/rel-1.9.1.1/DAIToolPlugins-rel1.9.1.x.yxi

Embedded example:
image

@achraf-mer achraf-mer marked this pull request as ready for review March 8, 2021 21:43
@achraf-mer achraf-mer requested review from nkpng2k and g-eoj March 8, 2021 21:43
@achraf-mer achraf-mer changed the title First go at adding support for DAI version 1.9.0.6 Add support for DAI version 1.9.0.6 Mar 8, 2021
@achraf-mer achraf-mer changed the title Add support for DAI version 1.9.0.6 Add Alteryx support for DAI version 1.9.0.6 Mar 8, 2021
@achraf-mer achraf-mer marked this pull request as draft March 8, 2021 21:53
@achraf-mer achraf-mer changed the title Add Alteryx support for DAI version 1.9.0.6 Add Alteryx support for DAI version 1.9.1 Mar 8, 2021
@achraf-mer achraf-mer changed the base branch from master to am/alteryx_dai_190 March 8, 2021 22:14
@achraf-mer achraf-mer marked this pull request as ready for review March 9, 2021 00:49
@achraf-mer achraf-mer requested review from nkpng2k and g-eoj March 9, 2021 00:50
nkpng2k
nkpng2k reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@nkpng2k nkpng2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments from other review. else, this is probably fine.

g-eoj
g-eoj approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@g-eoj g-eoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues, as we do have customers waiting on this. But using driverlessai in the future will have advantages, even if the requirements.txt has to be updated for new dai versions. I say I add autoviz to driverlessai, then make the switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkpng2k nkpng2k nkpng2k left review comments

@g-eoj g-eoj g-eoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achraf-mer @g-eoj @nkpng2k