-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor local logging #817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes it a lot cleaner!
For Log All Ranks
I would personally suggest to make this a global setting instead of an experiment setting.
Theoretically we could also add the same functionality for cfg.logging._logger.log
to also get rid of the if switches there.
If was going for it initially, but would need updating and passing of an environment variable to
Yes, though, most only support single rank logging there, so, I'd suggest we hardcode this in the external logger initialization and don't make it configuarable. |
closes #584