Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Testing, typing #841

Merged
merged 8 commits into from
Aug 21, 2024
Merged

[CHORE] Testing, typing #841

merged 8 commits into from
Aug 21, 2024

Conversation

pascal-pfeiffer
Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer commented Aug 20, 2024 •
edited
Loading

@pascal-pfeiffer pascal-pfeiffer linked an issue Aug 20, 2024 that may be closed by this pull request
[BUG]httpx.ReadTimeout && httpcore.ReadTimeout #822
Closed
@pascal-pfeiffer pascal-pfeiffer mentioned this pull request Aug 20, 2024
Closed
@pascal-pfeiffer pascal-pfeiffer marked this pull request as ready for review August 20, 2024 18:22
ybabakhin
ybabakhin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ybabakhin ybabakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pascal-pfeiffer pascal-pfeiffer merged commit 973d9b5 into main Aug 21, 2024
4 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the pp/chore branch August 21, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybabakhin ybabakhin ybabakhin approved these changes

@psinger psinger Awaiting requested review from psinger psinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]httpx.ReadTimeout && httpcore.ReadTimeout
2 participants
@pascal-pfeiffer @ybabakhin