fix: Use canvas renderer to avoid subtle G2 bugs. #1562 (#1587)

h2oai · Aug 15, 2022 · 13e6c5d · 13e6c5d
1 parent 33ba948
commit 13e6c5d
Show file tree

Hide file tree

Showing 3 changed files with 185 additions and 185 deletions.
diff --git a/py/examples/plot_theme.py b/py/examples/plot_theme.py
@@ -15,23 +15,18 @@
 f_cat_multi = FakeMultiCategoricalSeries(groups=k)
 f_scat = FakeScatter()
 
+zones = [
+    ui.zone(name='title', size='60px'),
+    ui.zone(name='plots', direction=ui.ZoneDirection.ROW, wrap='start', justify='center'),
+]
 
 @app('/demo')
 async def serve(q: Q):
     if not q.client.initialized:
         q.page['meta'] = ui.meta_card(box='', layouts=[
-            ui.layout(breakpoint='xs', zones=[
-                ui.zone(name='title'),
-                ui.zone(name='plots', direction=ui.ZoneDirection.ROW, wrap='start', justify='center'),
-            ]),
-            ui.layout(breakpoint='m', zones=[
-                ui.zone(name='title'),
-                ui.zone(name='plots', direction=ui.ZoneDirection.ROW, wrap='start', justify='center'),
-            ]),
-            ui.layout(breakpoint='xl', zones=[
-                ui.zone(name='title'),
-                ui.zone(name='plots', direction=ui.ZoneDirection.ROW, wrap='start', justify='center'),
-            ]),
+            ui.layout(breakpoint='xs', zones=zones),
+            ui.layout(breakpoint='m', zones=zones),
+            ui.layout(breakpoint='xl', zones=zones),
         ])
 
         q.client.active_theme = 'default'

diff --git a/tools/showcase/Makefile b/tools/showcase/Makefile
@@ -15,6 +15,7 @@ generate:
 
 visual-regression:
 	rm -rf test/compare test/diff
+	mkdir -p test/compare test/diff
 	./venv/bin/python showcase.py --test
 
 test-result: