Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough contrast between notification bar background and close button in h2o-dark theme #2241

Closed
nipunchamikara opened this issue Jan 29, 2024 · 1 comment · Fixed by #2249
Assignees
Labels
bug Bug in code ui Related to UI

Comments

@nipunchamikara
Copy link
Member

Wave SDK Version, OS

Wave v1.0.0
MacOS v14.3

Actual behavior

I'm currently working on a Wave App that has a light and dark mode, where it uses default and h2o-dark themes respectively. When using h2o-dark, the close button in notification bar is not discernible. It is visible when using the default theme.

  • default theme:
    image

  • h2o-dark theme:
    image

Expected behavior

Either the background of the notification bar should change with the theme, or the color of the close button should remain fixed.

Steps To Reproduce

  1. Set q.page["meta"].theme to h2o-dark
  2. Set q.page["meta"].notification_bar to ui.notification_bar component
@nipunchamikara nipunchamikara added the bug Bug in code label Jan 29, 2024
@mturoci
Copy link
Collaborator

mturoci commented Jan 29, 2024

Thanks for reporting @nipunchamikara!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants