Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give all widgets the name parameter #2350

Open
2 tasks
mtanco opened this issue Jun 11, 2024 · 3 comments
Open
2 tasks

Give all widgets the name parameter #2350

mtanco opened this issue Jun 11, 2024 · 3 comments
Labels
chore Chores feature Feature request good first issue Contributions welcome!

Comments

@mtanco
Copy link
Contributor

mtanco commented Jun 11, 2024

Is your feature request related to a problem? Please describe

It is very common to update parameters of components throughout the app usage lifecycle. This is most easily done with the name parameter, but not every component has that parameter. This means new-er users to the framework will learn about updating with the name component: q.page["test"].my_component.content = "hey" but then have no idea what to do when name is not there.

They can ("of course") use the old index method: q.page["test"].items[2].textbox.value="hey" but this is harder and often Wave users that joined after the 1.0.0 release will not know about this.

Describe the solution you'd like

  • An audit of all components to make a list of everything that does not have name as a parameter
  • Add name as a parameter to all of these

Describe alternatives you've considered

  • Leave things as is, monitor chats and teach people about the old method
  • Write new docs with key words that people might find when they try to update things like image

Additional context

Resolved question: #2338

@mtanco mtanco added feature Feature request chore Chores labels Jun 11, 2024
@mturoci mturoci added the good first issue Contributions welcome! label Jun 11, 2024
@Will-Marriott
Copy link

Hi - could I grab this issue, please?

@anirudhmehra12
Copy link

hey i want to fix this issue

@akhilk2802
Copy link

hey can you assign this issue to me

akwaed added a commit to akwaed/wave that referenced this issue Oct 1, 2024
Added name parameters to all applicable widgets
TODO: update doc description  to the affected types/members
akwaed added a commit to akwaed/wave that referenced this issue Oct 1, 2024
Added name parameters to all applicable widgets
TODO: update doc description  to the affected types/members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores feature Feature request good first issue Contributions welcome!
Projects
None yet
Development

No branches or pull requests

5 participants