Feat: timerpicker can't find second #2398 #2417
Open
+1,792
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added seconds select in time picker and updated the testing to be in format
mturoci
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks @akwaed. Seems like you have mixed branches with your previous PR. Please make sure this one only includes the relevant changes to the timepicker so that I can review the code properly. Moreover, would be good if you could also add a short demo video to PR description in order to show preview of your change.
|
@mturoci double-checked the files submitted for this PR and everything looks right. Did changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added seconds select in time picker and updated the testing to be in format
fixes: #2398
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.