Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: timerpicker can't find second #2398 #2417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akwaed
Copy link

@akwaed akwaed commented Oct 17, 2024

Added seconds select in time picker and updated the testing to be in format
fixes: #2398

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Added seconds select in time picker and updated the testing to be in format
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akwaed. Seems like you have mixed branches with your previous PR. Please make sure this one only includes the relevant changes to the timepicker so that I can review the code properly. Moreover, would be good if you could also add a short demo video to PR description in order to show preview of your change.

@akwaed
Copy link
Author

akwaed commented Oct 18, 2024

@mturoci double-checked the files submitted for this PR and everything looks right. Did changes to the ui/src/time_picker.test.tsx and ui/src/time_picker.tsx files only and the rest were automatically generated after rebuilding. Would upload the video before day's end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timerpicker can't find second
2 participants