Loading / Error centering #1
Conversation
There was a problem hiding this comment.
Thanks @mturoci. The theming part is not high priority. We need a good design for it because we want to provide the ability to access the theme colors from Python. Two major blockers to theming in its current state:
- Some apps like q-insights, etc. hard-code span colors for text blurbs - those will be unreadable in dark themes.
- Vega, Bokeh, Plotly, Matplotlib plots in their current state will look off.
- The native plots don't support theming yet.
It would be good to postpone this decision, and maybe just merge the eroor/loading centering.
ui/src/theme.ts
Outdated
| theme = { font, colors, merge, } | ||
| return theme | ||
| }, | ||
| getTheme = (): Theme => theme ? theme : loadTheme('light') | ||
| getTheme = (): Theme => theme ? theme : setTheme('dark') |
There was a problem hiding this comment.
Let's default to the light theme until we've worked out how to theme the plots, vega-lite, etc.
ui/src/theme.ts
Outdated
| card: '#0d0e0f', | ||
| page: '#1b1d1f', | ||
| }, 0), | ||
| palettes: Dict<ColorTheme> = { |
There was a problem hiding this comment.
This turns into palettes[x].palette at call sites. We need a good design to merge palette and theme.
|
Thanks for the review @lo5. I agree with postponing the decision so I reverted theming changes for now and kept just Loading / Error centering. |
Notes: The neon primary color was taken from DAI project, primary colors for the rest themes were chosen randomly and can be changed if we agree otherwise.