Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file upload cancel #1410

Merged
merged 11 commits into from
Jul 8, 2022
Merged

Allow file upload cancel #1410

merged 11 commits into from
Jul 8, 2022

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented May 10, 2022

Added option to cancel upload for ui.file_upload component for both large and compact mode.

  • Large:
Screen.Recording.2022-05-10.at.14.41.20.mov
  • Compact:
Screen.Recording.2022-05-10.at.15.00.11.mov

Closes #1205

@marek-mihok marek-mihok linked an issue May 10, 2022 that may be closed by this pull request
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok! A few comments from me. Please test the proposed changes cross-browser.

ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
ui/src/file_upload.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok!

@mturoci mturoci merged commit 6117b96 into master Jul 8, 2022
@mturoci mturoci deleted the feat/issue-1205 branch July 8, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow file upload cancel
2 participants