Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 fix: using r.Host if post_logout_redirect_url not set #1504

Merged
merged 1 commit into from
Jun 16, 2022
Merged

🐞 fix: using r.Host if post_logout_redirect_url not set #1504

merged 1 commit into from
Jun 16, 2022

Conversation

henrycs
Copy link
Contributor

@henrycs henrycs commented Jun 16, 2022

I found the new feature not worked in my project, after checking code, I fixed this issue, would you please help me review the change? thanks!

@henrycs henrycs requested review from lo5 and mturoci as code owners June 16, 2022 07:56
mturoci
mturoci approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @henrycs!

@mturoci mturoci merged commit 7a504d6 into h2oai:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrycs @mturoci