Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow user to unselect user typed choice #1533

Merged
merged 3 commits into from
Jul 11, 2022
Merged

fix: allow user to unselect user typed choice #1533

merged 3 commits into from
Jul 11, 2022

Conversation

aalencar
Copy link
Contributor

@aalencar aalencar commented Jul 8, 2022

Setting selected flag for options items was messing up how we control what is selected. selected array should be responsible for that.

closes #1523

@aalencar aalencar requested review from lo5 and mturoci as code owners July 8, 2022 09:51
mturoci
mturoci reviewed Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aalencar, can you please add some unit tests as well so that we are sure this bug doesn't resurface again?

@aalencar aalencar requested a review from mturoci July 11, 2022 09:07
mturoci
mturoci approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aalencar!

@mturoci mturoci merged commit 989d2c8 into master Jul 11, 2022
@mturoci mturoci deleted the fix/issue-1523 branch July 11, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combobox custom value cannot be unselected
2 participants
@aalencar @mturoci