Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add icon to masked textfield component #1536 #1539

Merged
merged 4 commits into from
Jul 18, 2022
Merged

fix: Add icon to masked textfield component #1536 #1539

merged 4 commits into from
Jul 18, 2022

Conversation

aalencar
Copy link
Contributor

closes #1536

mturoci
mturoci reviewed Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aalencar. Seems like there are more missing props though. Let's create a single Fluent.ITextFieldProps that will be passed into both MaskedTextField and TextField to have this resolved once and for all.

@aalencar aalencar requested a review from mturoci July 14, 2022 13:14
mturoci
mturoci requested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include data-test within textFieldProps?

@aalencar
Copy link
Contributor Author

Can we also include data-test within textFieldProps?

Let's use textFieldProps only for Fluent.ITextFieldProps properties.

@mturoci
Copy link
Collaborator

mturoci commented Jul 15, 2022

Let's use textFieldProps only for Fluent.ITextFieldProps properties.

Why?

@aalencar
Copy link
Contributor Author

Let's use textFieldProps only for Fluent.ITextFieldProps properties.

Why?

data-test is not part of Fluent.ITextFieldProps

@mturoci
Copy link
Collaborator

mturoci commented Jul 15, 2022

That's fine. The goal here is to have a single source of truth for common props.

@aalencar
Copy link
Contributor Author

Ok

@mturoci mturoci merged commit 610c021 into master Jul 18, 2022
@mturoci mturoci deleted the fix/issue-1536 branch July 18, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Bug For Textbox Component When Setting Mask Parameter
2 participants
@aalencar @mturoci