Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not serve JS files with plaintext MIME type on Windows by upgrading go to 1.19. #1811

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: Do not serve JS files with plaintext MIME type on Windows by upgrading go to 1.19. #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-go@v1
with:
go-version: '1.16'
go-version: '1.19.4'

- name: Setup
run: make all
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-wave-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- uses: actions/setup-go@v1
with:
go-version: '1.16'
go-version: '1.19.4'

- name: Setup
run: make setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-wave.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- uses: actions/setup-go@v1
with:
go-version: '1.16'
go-version: '1.19.4'

- name: Setup
run: make setup
Expand Down
8 changes: 4 additions & 4 deletions website/docs/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ If you discover a security vulnerability within H2O Wave, please send an email t

## Code of Conduct

See https://github.com/h2oai/wave/blob/master/.github/CODE_OF_CONDUCT.md.
See <https://github.com/h2oai/wave/blob/master/.github/CODE_OF_CONDUCT.md>.

## Development Setup

Prerequisites:

- [Go](https://golang.org/) v1.16+
- [Go](https://golang.org/) v1.19+
- [Node.js](http://nodejs.org) v16+
- [Python](https://www.python.org/) 3.7+
- A C/C++ compiler [XCode](https://developer.apple.com/xcode/) on OSX, `build-essential` on Debian, `base-devel` on Arch, etc.) to build Python/Node.js dependencies.
Expand All @@ -77,7 +77,7 @@ cd wave
make all
```

Launch the Wave server at http://localhost:10101/
Launch the Wave server at <http://localhost:10101/>

``` bash
make run
Expand All @@ -98,7 +98,7 @@ wave run examples.button

All examples are located in [py/examples](https://github.com/h2oai/wave/tree/master/py/examples) folder.

If you intend to modify the UI (Typescript), also launch the UI development server at http://localhost:3000/ to watch and hot-reload your modifications. Open `./ui` in Visual Studio Code or your preferred IDE.
If you intend to modify the UI (Typescript), also launch the UI development server at <http://localhost:3000/> to watch and hot-reload your modifications. Open `./ui` in Visual Studio Code or your preferred IDE.

``` bash
make run-ui
Expand Down