-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make dynamic value change consistent #2118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
marek-mihok
force-pushed
the
fix/make-dynamic-value-change-consistent
branch
from
August 22, 2023 11:45
5e73562
to
25f83bd
Compare
mturoci
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok!
marek-mihok
added a commit
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all that apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.This PR addresses all issues found after final revision of #1154. Included issues are:
None
, select value manually, set values toNone
once again (unable to set toNone
)ui.tab_card
only, but not forui.tabs
- try to set value dynamically, select tab manually, set value dynamically to the same value as before (Tab is not switching)choices
are set toNone
it leads to endless loopchoices
are set toNone
it leads to endless loopvalue=None
within the Wave app when component was initially rendered with some valueAlso this PR adjusts the behavior of Nav/Tab/Tabs in following manner:
None
, no item is activeNone
, first item is active by default - we are not bringing support for Allow for no selected tab in tabs group #1776Closes #1154
Closes #1776