Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make dynamic value change consistent #2118

Merged
merged 21 commits into from
Aug 24, 2023

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Aug 21, 2023

The PR fulfills these requirements: (check all that apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

This PR addresses all issues found after final revision of #1154. Included issues are:

  • Checklist - set values to None, select value manually, set values to None once again (unable to set to None)
  • Tabs - dynamic value change is fully supported for ui.tab_card only, but not for ui.tabs - try to set value dynamically, select tab manually, set value dynamically to the same value as before (Tab is not switching)
  • Combobox single/multi - when choices are set to None it leads to endless loop
  • Dropdown - dialog single/multi - when choices are set to None it leads to endless loop
  • Nav - user was unable to dynamically unselect all items by specifying value=None within the Wave app when component was initially rendered with some value

Also this PR adjusts the behavior of Nav/Tab/Tabs in following manner:

  • Revert behavior for Menu - when value is set to None, no item is active
  • Keep behavior for Tab/Tabs - when value is set to None, first item is active by default - we are not bringing support for Allow for no selected tab in tabs group #1776
  • Args setting is consistent

Closes #1154
Closes #1776

@marek-mihok marek-mihok force-pushed the fix/make-dynamic-value-change-consistent branch from 5e73562 to 25f83bd Compare August 22, 2023 11:45
@marek-mihok marek-mihok marked this pull request as ready for review August 23, 2023 15:20
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok!

@mturoci mturoci merged commit 2afd7c0 into main Aug 24, 2023
2 checks passed
@mturoci mturoci deleted the fix/make-dynamic-value-change-consistent branch August 24, 2023 13:51
mturoci pushed a commit that referenced this pull request Aug 24, 2023
marek-mihok added a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for no selected tab in tabs group Unify value behavior
2 participants