Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear dirty UI state across clients on broadcast/multicast user interaction for consistency. #1705 #2123

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Aug 31, 2023

The root cause of the problem described in the corresponding issue was:

  • Client1 renders a form with value.
  • UI changes are propagated to the rest of connected clients, (client2).
  • UI state is set as dirty in the browser side, due to explicit textbox value. State is same across all clients.
  • Client1 clicks the button, q.args with the correct state (btn + textbox) is submitted and cleared.
  • UI changes are propagated to all the clients again, but now client1 has fresh UI state, while client2 has the old one still as there was no user interaction that would submit and clear the local args (local state).

This PR sends a clear event to all the connected clients whenever user interaction happens on any of them.

Closes #1705

@mturoci mturoci requested a review from lo5 as a code owner August 31, 2023 08:27
@mturoci mturoci merged commit 95b73f3 into main Sep 4, 2023
2 checks passed
@mturoci mturoci deleted the fix/issue-1705 branch September 4, 2023 06:23
marek-mihok pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected q.args for multi- or broadcast
1 participant