Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add e2e tests for showing clipboard copy button #2025 #2128

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

This PR adds e2e tests for #2025.

Unit tests for testing the button visibility on hover over copyable_text/markdown code block were not enough due to limitations of nwsapi lib used by JSDOM.

@marek-mihok marek-mihok marked this pull request as ready for review September 6, 2023 21:34
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @marek-mihok!

…markdown code block and multiline copyable text
@mturoci mturoci force-pushed the feat/e2e-clipboard-copy-button branch from 2bb1257 to 74cbb07 Compare September 7, 2023 06:56
@mturoci mturoci merged commit 741e8a0 into main Sep 7, 2023
2 checks passed
@mturoci mturoci deleted the feat/e2e-clipboard-copy-button branch September 7, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants