Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set ui.inline justify default to start #2267 #2272

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Feb 21, 2024

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Adds lacking start default to ui.inline() justification as declared in the API description.

This change affects only one example:
image

Closes #2267

@mturoci
Copy link
Collaborator

mturoci commented Feb 23, 2024

Shouldn't the screenshots show the opposite? The goal of the issue is setting the alignment to start so that elements are in a row starting from left, progressing to the right taking up only their intrinsic size. The screenshots look like they are using some kind of space-between variant or something.

@marek-mihok
Copy link
Contributor Author

that elements are in a row starting from left, progressing to the right taking up only their intrinsic size

@mturoci , the left part of the screenshot is the fixed implementation and the "space-between" variant is the old (wrong) one.

@mturoci
Copy link
Collaborator

mturoci commented Feb 23, 2024

Got it. I assumed you are showing the change this PR introduced, hence base = old, compare = new. If it's the opposite, all is good.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mturoci mturoci merged commit 261e506 into main Feb 23, 2024
2 checks passed
@mturoci mturoci deleted the feat/issue-2267 branch February 23, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wave1.0.0 ui.inline() default value for justify is not "start"
2 participants