Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include spacing in width for inline horizontal components #2251 #2273

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Feb 21, 2024

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

The problem was that left margin for ui.inline horizontally laid components adds to total component width causing the overflow. Since something like boxSizing: "margin-box" does not exist, the issue is fixed by replacing left margin with left padding and using boxSizing: "border-box" which accounts for both borders and paddings when calculating component dimensions.

image

This PR also includes a fix for firefox visual regression tests incompatibility with new H2O_WAVE_RECONNECT_TIMEOUT (#2252).

Solution tested across all browsers.
Also both unit and visual regression tests pass.

Closes #2251

@marek-mihok marek-mihok marked this pull request as ready for review February 22, 2024 15:40
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mturoci mturoci merged commit ba84772 into main Feb 23, 2024
2 checks passed
@mturoci mturoci deleted the feat/issue-2251 branch February 23, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in width handling since v0.26.3 makes handling of inline objects difficult
2 participants