fix: Include spacing in width for inline horizontal components #2251 #2273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.The problem was that left margin for ui.inline horizontally laid components adds to total component width causing the overflow. Since something like
boxSizing: "margin-box"
does not exist, the issue is fixed by replacing left margin with left padding and usingboxSizing: "border-box"
which accounts for both borders and paddings when calculating component dimensions.This PR also includes a fix for firefox visual regression tests incompatibility with new
H2O_WAVE_RECONNECT_TIMEOUT
(#2252).Solution tested across all browsers.
Also both unit and visual regression tests pass.
Closes #2251