-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented a tooltip for table column headers #2349
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nivzx!
- The tooltip is too far away from the icon.
- Hovering over icon shouldn't bring up pointer cursor since clicking the info icon triggers no action.
- The table column styling should remain intact.
- Please add a unit tests to verify that the info button with tooltip is only rendered when
tooltip
prop is specified on a col. Columns without the prop should not render the info icon.
Fixed the styling issues. Will update the tests. Meanwhile please let me know your thoughts.
|
…the columns where `tooltip` option is specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table styling should remain intact as mentioned previously.
You can use our visual regression testing tool:
- Checkout main
make build-ui
cd tools/showcase && make visual-regression
- chekout your feature branch
make build-ui
cd tools/showcase && make visual-regression
make test-result
.
See Makefile
in tools/showcase
for more info.
The tooltip is not centered, the icon is way too small and the spacing between other column icons is uneven.
Also, the tooltip probably needs either a border or slightly different background so that it's easier to spot:
Maybe needed for the rest of the tooltips as well so prefer generic solution.
Got it! I'll try to refine this further. Thanks! |
cc: @mturoci |
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Closes #1792
Added a optional
tooltip
parameter totable_column
The column header with
tooltip
property is displayed with a tooltip icon and the tooltip content is displayed when it's hovered.cc @mturoci