Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🔒Enable and enforce boringcrypto experiment #2353

Merged
merged 1 commit into from
Jun 24, 2024
Merged

build: 🔒Enable and enforce boringcrypto experiment #2353

merged 1 commit into from
Jun 24, 2024

Conversation

zoido
Copy link
Contributor

@zoido zoido commented Jun 20, 2024

GOEXPERIMENT=boringcrypto switches crypto packages to call BoringCrypto library. It is included as a precompiled object with Go distibution so can be linked to statically.

We want to have all binaries consistently built this way to get closer to FIPS 140 compliance.

`GOEXPERIMENT=boringcrypto` switches `crypto` packages to call BoringCrypto library. It is included as a precompiled object with Go distibution so can be linked to statically.

We want to have all  binaries consistently built this way to get closer to FIPS 140 compliance.
@zoido zoido marked this pull request as ready for review June 21, 2024 11:31
@zoido zoido requested review from lo5 and mturoci as code owners June 21, 2024 11:31
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zoido! Code LGTM, I also verified this works by running waved against self-signed certificate.

@mturoci mturoci merged commit bf87803 into h2oai:main Jun 24, 2024
@zoido zoido deleted the lp/boringcrypto branch June 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants