fix: Dropdown of filterable columns not always visible #2400 #2414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Closes #2400
I have fixed this bug, which was a regression that I introduced in PR #2371.
This was resolved by adding wrapping the column name in a
span
and adding styling to hide overflow text and replace with an ellipsis. The code looks like this:I made local changes to the
table.py
example to have some really long names and made sure the text is properly clipped and that sorting icon and filtering stuff still works fine. Here's a screen shot:And here's a short video:
Issue2400_ui_test.mov
I tried creating a new unit test, but that didn't work as I initially expected. No matter how long the column name was, the document always had the entire content. I guess that makes sense since the rendering of the ellipses will occur in the browser. If I'm overlooking something and there is a way to write a unit test for this, please advise.
I did re-run all the existing unit tests and they worked fine:
Let me know if you have any questions or would like me to make any changes. Thanks!