Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose "bool response=false" from writeValue in setValue(..., bool response=false) #157

Closed
fightforlife opened this issue Dec 18, 2020 · 4 comments

Comments

@fightforlife
Copy link

Hi there,

would it be possible to expose the parameter bool response=false"
from NimBLEremoteCharacteristics::writeValue (const std::string &newValue, bool response=false)
as an optional (fourth) parameter in
NimBLEClient::setValue (const NimBLEUUID &serviceUUID, const NimBLEUUID &characteristicUUID, const std::string &value, bool response=false)

Some of my devices only work with bool response=true. (e.g. eQ3 ble thermostats)
And this would really help to declutter alot of my code.

Thanks in advance!

@fightforlife fightforlife changed the title expose "bool response=false" from NimBLEremoteCharacteristics::writeValue in NimBLEClient::setValue(..., bool response=false) expose "bool response=false" from writeValue in setValue(..., bool response=false) Dec 18, 2020
@h2zero
Copy link
Owner

h2zero commented Dec 19, 2020

Sure, that could be added easily enough. If you want to make a PR for it please do so. Otherwise I can add it with the other updates this weekend.

@h2zero
Copy link
Owner

h2zero commented Dec 24, 2020

@fightforlife this has been added in commit 135e2fa. Please let me know if this works for you.

@h2zero
Copy link
Owner

h2zero commented Dec 29, 2020

Closing this as resolved.

@h2zero h2zero closed this as completed Dec 29, 2020
@fightforlife
Copy link
Author

Thank you very much. I just had time to test this and it is working as expceted!

h2zero pushed a commit that referenced this issue Jun 4, 2024
…te callback (#157)

Updates the interface to use a typedef'd std::function for the advertise callback, which is backwards compatible but also allows std::bind and lambda functions.
h2zero pushed a commit that referenced this issue Jun 15, 2024
…te callback (#157)

Updates the interface to use a typedef'd std::function for the advertise callback, which is backwards compatible but also allows std::bind and lambda functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants