Merge bugfix into master #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved default handling of connection parameter updates. Assert added for the creation of a 2902 descriptor on a characteristic without notification or indication properties. Multiple 2902 descriptors are now silently prevented from being created on the same characteristic. Initial experimental code implemented to handle long read and writes /* commented out for now */
Added example usage to NimBLE_Client.ino.
Add getPower() method to NimBLEDevice. Use esp power level in advertising txPower.
…into bugfix # Conflicts: # README.md
Added cccd store overflow handling from NimBLE PR #790.
Move the mtu exchange call to the client connect function from the event handler as it triggered a LoadStoreError previously. Return 0 in remote characteristic write instead of status->error. Add a delay to permit task switching when starting scan or connect procedure. Log levels now work correctly when using arduino as an IDF component.
Test for BLE_HS_DONE return code in client connect and scan start loops.
setConnectionParams() no longer takes min/max connection event time as arguments as they are not used by NimBLE. Added setting of scan interval and window to connection parameters to allow custom scan settings when finding the connection target. Added define for IDF v3.3
Update examples.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.