Resync to esp-nimble master+patches #15
Merged
+882
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
resync-to-esp-nimble-master+patches
branch
from
e59df0e to
1c0aafd
Compare
esp-idf @be8c847 esp-nimble@0a1604a
h2zero
force-pushed
the
resync-to-esp-nimble-master+patches
branch
from
e3ca80e to
0aaa558
Compare
esp-nimble#7
mynewt-nimble #790
mynewt-nimble#802
Removed previouly un-merged patches for unbonded CCCD storage and `ble_hs_misc_conn_chan_find_reqd()` null pointer exception fix. Applied offically merged versions: mynewt-nimble #730 - nimble/host: Fix setting connection flags after pairing mynewt-nimble #804 - nimble/gap: Fix storing CCC for bonded devices. mynewt-nimble #802 - nimble/host: Add return parameter to the ble_hs_misc_conn_chan_find_reqd() Retaining un-merged: esp-nimble #7 - Allow host to resolve peer RPA without using local RPA.
The NimBLE core library that this project is based on has been patched to improve functionality. This new folder contains the patch files applied that have not yet been merged offically into the esp-nimble fork. The offical-merged folder contains patches that are offically applied to the upstream NimBLE core, the un-merged folder contains the patches not yet merged anywhere.
The NimBLE controller does not make use of the Minimum and Maximum Connection Event lengths but the ESP32 controller does. The NimBLE default values create error conditions in the ESP32 controller when connecting to multiple peers with connection intervals. This patch sets those parameters to 0 to allow the controller to manage the time window.
This updates the esp-nimble #7 patch to the latest PR.
h2zero
force-pushed
the
resync-to-esp-nimble-master+patches
branch
from
0aaa558 to
9eca05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts this library back in sync with the esp-nimble and esp-idf upstream repos and applies some important patches from mynewt/nimble master that are not yet in esp-nimble. Also esp-nimble PR#7 has been applied, although not yet approved/merged, has been well tested to work.
All patch files used are in the applied_patches folder for reference.
These patches address some performance and reliability issues as well as issues brought up in this repo.