Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search accounts/tags/statuses #23

Closed
h3poteto opened this issue Nov 10, 2022 · 3 comments · Fixed by #1142
Closed

Search accounts/tags/statuses #23

h3poteto opened this issue Nov 10, 2022 · 3 comments · Fixed by #1142
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@h3poteto
Copy link
Owner

h3poteto commented Nov 10, 2022

I'm thinking about where the search panel should be located.

  • 👎 Modal: Easy, but what happens when we click the tag or account? A new tag timeline is displayed?
  • 👎 Timeline: Search results are not a timeline. And I don't want to specify a server before creating a search tab.
  • 👍 Sidebar like compose: Switch compose or search tab.
@h3poteto h3poteto added this to the 1.0.0 milestone Nov 10, 2022
@h3poteto h3poteto added feature enhancement New feature or request and removed feature labels Nov 15, 2022
@h3poteto h3poteto modified the milestones: 1.0.0, 2.0.0 Dec 17, 2022
@h3poteto h3poteto modified the milestones: 2.0.0, 1.3.0 Mar 9, 2023
@GrahamDo
Copy link

GrahamDo commented Apr 5, 2023

My 2c: A search icon on the sidebar just below the New Post tab. Clicking it pops out a floating panel with a textbox. Type your query, hit ENTER, and it open the results in a new column. By default, it searches on the server your first active account is on... Or perhaps the last account you used to post. Or maybe there's a new setting to specify the default server to use for searches.

On the top of the search column (or maybe hidden behind the Column Settings button), there's a dropdown that lets you change the server on which this search is being performed (you can only pick between the servers that you've linked accounts for, obviously).

Most users won't care, since for all intents and purposes, it doesn't really matter which server you perform a search on because the search is always effectively across the entire fediverse.

What do you think?

@h3poteto
Copy link
Owner Author

h3poteto commented Apr 5, 2023

Clicking it pops out a floating panel with a textbox
and it open the results in a new column

This is confusing. The results should be displayed near the search textbox.

On the top of the search column (or maybe hidden behind the Column Settings button), there's a dropdown that lets you change the server on which this search is being performed

I agree, I will adopt this idea.

Most users won't care, since for all intents and purposes, it doesn't really matter which server you perform a search on because the search is always effectively across the entire fediverse.

Hmm...... I understand what you say. However, it is hard to do this now. Because some results are duplicates when we search a word across all servers. For example, when I search the tag "#fedistar", both server "A" and server "B" have #fedistar tag. So multiple results for the same tag are displayed. But they are separate timelines (The tag timeline of #fedsitar in server "A" and the tag timeline of #fesitar in server "B" are different).

@GrahamDo
Copy link

GrahamDo commented Apr 6, 2023

This is confusing. The results should be displayed near the search textbox.

You're right. It was me who was being confused. There's a difference between the search results and the hashtag/user you click. I'm trying to think of it in terms of how TweetDeck and Sengi (the Mastodon client I currently use) work. And you're right: you type your query in the textbox and hit ENTER, and the results appear just below the textbox.

So in fact, I guess, below the textbox, you could have a little dropdown or expandable thing that says, "Search using this server", and have it default as I described.

(Sengi's already got a concept of an "Active/Default Account". It's whatever profile picture you click on before you do anything. There's always one selected (and you'll identify it because it's glowing whereas all other accounts are dull) and everything, from searching to posting, happens in the context of that account. But I'm not a massive fan of that approach, so I think yours is actually much better)

Anyway, here's what Sengi's search panel looks like:

image

That's not a column: it expands out under the textbox as soon as I hit ENTER, and it floats above the right-most column. I can click the X in the top-right to close it. But if I click on the hashtag or the status or the user in those results, it will then open that hashtag or status or user in a new column.

@h3poteto h3poteto modified the milestones: 2.0.0, 1.7.0 Jun 29, 2023
h3poteto added a commit that referenced this issue Aug 26, 2023
h3poteto added a commit that referenced this issue Aug 27, 2023
h3poteto added a commit that referenced this issue Aug 27, 2023
h3poteto added a commit that referenced this issue Aug 28, 2023
h3poteto added a commit that referenced this issue Aug 28, 2023
h3poteto added a commit that referenced this issue Aug 28, 2023
h3poteto added a commit that referenced this issue Aug 28, 2023
refs #23 Add search feature for hashtags
@h3poteto h3poteto self-assigned this Sep 7, 2023
h3poteto added a commit that referenced this issue Sep 15, 2023
h3poteto added a commit that referenced this issue Sep 15, 2023
refs #23 Add search feature for statuses
h3poteto added a commit that referenced this issue Sep 15, 2023
h3poteto added a commit that referenced this issue Sep 16, 2023
refs #23 Submit search form with enter key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants