Correctly parse Misskey object emoji format #1816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that while Megalodon assumes that Misskey emojis come down in an array, in my testing, they have the same format as the
reactionEmojis
: that is to say, an object of key (shortcode) value (url) pairs. This change uses the same logic as for mapping emoji reactions to generate the emojis list.I don't know if older versions of Misskey presented the
emojis
field as an array, so I've kept in the old logic for backwards compatibility. Both instances I tested on (misskey.io and misskey.design) exhibited the new behavior.The
emojis
field is not mentioned at all in the API docs, so I don't have a source of truth other than my test requests.